Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9969][YARN] Remove old MR classpath API support #8192

Closed
wants to merge 1 commit into from

Conversation

jerryshao
Copy link
Contributor

Here propose to remove old MRJobConfig#DEFAULT_APPLICATION_CLASSPATH support, since we now move to Yarn stable API.

@vanzin and @sryza , any opinion on this? If we still want to support old API, I can close it. But as far as I know now major Hadoop releases has moved to stable API.

@srowen
Copy link
Member

srowen commented Aug 14, 2015

This would prevent Hadoop 1.x from working, right? or would it?
I think that's still required, although I would also advocate for dropping 1.x support.

@jerryshao
Copy link
Contributor Author

I think it is Spark on Yarn specific code, will not impact hadoop 1.x.

@jerryshao
Copy link
Contributor Author

Since Hadoop 1.x will not even compile Yarn related module.

@SparkQA
Copy link

SparkQA commented Aug 14, 2015

Test build #40855 timed out for PR 8192 at commit 07a4e4f after a configured wait of 175m.

@vanzin
Copy link
Contributor

vanzin commented Aug 14, 2015

The change itself LGTM, but I wonder whether this code is needed at all. Shouldn't the YARN classpath be sufficient?

@SparkQA
Copy link

SparkQA commented Aug 15, 2015

Test build #1619 has finished for PR 8192 at commit 07a4e4f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

@vanzin, not specifically sure about why need MR default classpath, I guess we still need some APIs for HadoopRDD related codes.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 17, 2015

Test build #41005 timed out for PR 8192 at commit 07a4e4f after a configured wait of 175m.

@sryza
Copy link
Contributor

sryza commented Aug 18, 2015

Yeah, it's needed for the InputFormats that Spark relies on to read Hadoop data.

@vanzin
Copy link
Contributor

vanzin commented Aug 18, 2015

Let's try once again. retest this please

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41170 timed out for PR 8192 at commit 07a4e4f after a configured wait of 175m.

@vanzin
Copy link
Contributor

vanzin commented Aug 19, 2015

All the yarn tests ran and passed, so I'm gonna merge this.

@vanzin
Copy link
Contributor

vanzin commented Aug 19, 2015

Merged to master, thanks!

@asfgit asfgit closed this in 1f89029 Aug 19, 2015
@jerryshao
Copy link
Contributor Author

Thanks @vanzin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants