-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-9969][YARN] Remove old MR classpath API support #8192
Conversation
This would prevent Hadoop 1.x from working, right? or would it? |
I think it is Spark on Yarn specific code, will not impact hadoop 1.x. |
Since Hadoop 1.x will not even compile Yarn related module. |
Test build #40855 timed out for PR 8192 at commit |
The change itself LGTM, but I wonder whether this code is needed at all. Shouldn't the YARN classpath be sufficient? |
Test build #1619 has finished for PR 8192 at commit
|
@vanzin, not specifically sure about why need MR default classpath, I guess we still need some APIs for HadoopRDD related codes. |
Jenkins, retest this please. |
Test build #41005 timed out for PR 8192 at commit |
Yeah, it's needed for the InputFormats that Spark relies on to read Hadoop data. |
Let's try once again. retest this please |
Test build #41170 timed out for PR 8192 at commit |
All the yarn tests ran and passed, so I'm gonna merge this. |
Merged to master, thanks! |
Thanks @vanzin :) |
Here propose to remove old MRJobConfig#DEFAULT_APPLICATION_CLASSPATH support, since we now move to Yarn stable API.
@vanzin and @sryza , any opinion on this? If we still want to support old API, I can close it. But as far as I know now major Hadoop releases has moved to stable API.