Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10019][MLlib]: ML model broadcasts should be stored in private vars: mllib IDFModel #8248

Closed
wants to merge 2 commits into from
Closed

[SPARK-10019][MLlib]: ML model broadcasts should be stored in private vars: mllib IDFModel #8248

wants to merge 2 commits into from

Conversation

sabhyankar
Copy link

ML model broadcasts should be stored in private vars: mllib IDFModel.
Applies to: spark.mllib.feature.IDFModel

@feynmanliang feynmanliang mentioned this pull request Aug 24, 2015
Closed
@feynmanliang
Copy link
Contributor

Can you close this PR and include changes with #8241 ?

@feynmanliang feynmanliang mentioned this pull request Aug 24, 2015
Closed
@mengxr
Copy link
Contributor

mengxr commented Aug 27, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Aug 27, 2015

Test build #41694 has finished for PR 8248 at commit 98fa159.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sabhyankar
Copy link
Author

@mengxr I am going to update PRs #8248 #8247 #8243 #8241 and #8249 after PR #8241 is merged to trunk. This is needed because we want to use the common trait (Broadcastable) that is added in #8241 for the other PRs.

FYI @feynmanliang @jkbradley

@sabhyankar sabhyankar closed this Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sabhyankar @feynmanliang @mengxr @SparkQA