Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SparkR][Minor] Get rid of a long line warning #8297

Closed
wants to merge 1 commit into from
Closed

[SparkR][Minor] Get rid of a long line warning #8297

wants to merge 1 commit into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Aug 19, 2015 

R/functions.R:74:1: style: lines should not be more than 100 characters.
            jc <- callJStatic("org.apache.spark.sql.functions", "lit", ifelse(class(x) == "Column", x@jc, x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 19, 2015

@shivaram could you review it, please? Thank you for your continuous support.

@shivaram
Copy link
Contributor

LGTM. I thought this was a part of some other open PR ?

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 19, 2015

Right. However, I thought we should isolate the validation problem for #7883. So I reverted it on other PR under review.

@shivaram
Copy link
Contributor

Ok cool. I'll merge this first after Jenkins passes and then we can retest #7883.

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41195 has finished for PR 8297 at commit b3ff9f0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in b4b35f1 Aug 19, 2015
asfgit pushed a commit that referenced this pull request Aug 19, 2015
@yu-iskw @shivaram
[SPARKR] [MINOR] Get rid of a long line warning
0a1385e 
```
R/functions.R:74:1: style: lines should not be more than 100 characters.
            jc <- callJStatic("org.apache.spark.sql.functions", "lit", ifelse(class(x) == "Column", xjc, x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>

Closes #8297 from yu-iskw/minor-lint-r.

(cherry picked from commit b4b35f1)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 19, 2015

@shivaram thank you for reviewing and merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yu-iskw @shivaram @SparkQA