-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 1.6.0-SNAPSHOT. #8350
Conversation
Test build #41352 has finished for PR 8350 at commit
|
Test build #41356 has finished for PR 8350 at commit
|
@@ -295,6 +295,18 @@ | |||
<enabled>false</enabled> | |||
</snapshots> | |||
</repository> | |||
<!-- TODO: This can be deleted after Spark 1.5 is posted --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks fine; does this particular change belong only in the 1.5 branch though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure -- I followed Patrick's last pr of this kind.
What happened without this is that Mima would fail and complain about all classes we marked as exclude for 1.5. I actually don't know exactly how mima works. Adding this doesn't seem to help much either.
@rxin Now that 1.5 has been released, we should merge this ? |
Test build #1732 has finished for PR 8350 at commit
|
Yes, I think this needs MIMA entries for 1.6 now too. |
Test build #42369 has finished for PR 8350 at commit
|
I started on figuring out what MiMa excludes have to be brought forward and got this far before being tripped up by more local SBT errors:
Try adding this, running |
I think if you update previousVersion in MimaBuild.scala many of these should go away. I'm happy to look at the error output after doing that. |
Test build #42450 has finished for PR 8350 at commit
|
I tested it locally, you'll need something like this:
|
Test build #42455 has finished for PR 8350 at commit
|
Test build #42460 has finished for PR 8350 at commit
|
Test build #1754 has finished for PR 8350 at commit
|
Hm - this is a test file that is in the source folder, so MIMA is On Mon, Sep 14, 2015 at 10:29 PM, Apache Spark QA notifications@github.com
|
Test build #42469 has finished for PR 8350 at commit
|
Alright I'm going to merge this. |
I think that's reasonable since the only failure mode this patch should cause is MiMa failure and that passed now. Thanks @pwendell for reminding me about the previousVersion thing, had totally overlooked how that worked. |
No problem - I should have caught it earlier. Hopefully people didn't spin On Tue, Sep 15, 2015 at 12:56 AM, Sean Owen notifications@github.com
|
No description provided.