Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-9791] Change private class to private[package] class to prevent unnecessary classes from showing up in the docs #8387

Closed
wants to merge 1 commit into from
Closed

[SPARK-9791] Change private class to private[package] class to prevent unnecessary classes from showing up in the docs #8387

wants to merge 1 commit into from

Conversation

tdas
Copy link
Contributor

@tdas tdas commented Aug 24, 2015

In addition, some random cleanup of import ordering

@tdas
Copy link
Contributor Author

tdas commented Aug 24, 2015

@zsxwing please take a look

@zsxwing
Copy link
Member

zsxwing commented Aug 24, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #41438 has finished for PR 8387 at commit 67f3ee9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas tdas changed the title [SPARK-979] Change private class to private[package] class to prevent unnecessary classes from showing up in the docs [SPARK-9791] Change private class to private[package] class to prevent unnecessary classes from showing up in the docs Aug 24, 2015
@tdas
Copy link
Contributor Author

tdas commented Aug 24, 2015

Thanks @zsxwing merging this to master and 1.5

asfgit pushed a commit that referenced this pull request Aug 24, 2015
@tdas
[SPARK-9791] [PACKAGE] Change private class to private class to preve…
d003373 
…nt unnecessary classes from showing up in the docs

In addition, some random cleanup of import ordering

Author: Tathagata Das <tathagata.das1565@gmail.com>

Closes #8387 from tdas/SPARK-9791 and squashes the following commits:

67f3ee9 [Tathagata Das] Change private class to private[package] class to prevent them from showing up in the docs

(cherry picked from commit 7478c8b)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in 7478c8b Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tdas @zsxwing @SparkQA