[SPARK-10176][SQL] Show partially analyzed plans when checkAnswer fails to analyze #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: sql/hive/src/test/scala/org/apache/spark/sql/hive/MultiDatabaseSuite.scala
marmbrus
changed the title
|
Test build #41441 has finished for PR 8389 at commit
|
Conflicts: sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
|
Test build #41477 has finished for PR 8389 at commit
|
Conflicts: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompatibilityTest.scala sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala
|
Test build #41562 has finished for PR 8389 at commit
|
Conflicts: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompatibilityTest.scala
|
Test build #41787 has finished for PR 8389 at commit
|
marmbrus
changed the title
|
@andrewor14 this is ready to review |
| @@ -17,11 +17,12 @@ | |||
|
|
|||
| package org.apache.spark.sql.hive | |||
|
|
|||
| import org.apache.spark.sql.hive.test.TestHiveSingleton | |||
There was a problem hiding this comment.
nit import order, should move down
|
Hi @marmbrus @cloud-fan all my comments are minor and this is mergeable as is, but I have two high level comments: (1) I think we should always put (2) Could we make |
|
Deferring to #8584 |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2015
…ils to analyze This PR takes over #8389. This PR improves `checkAnswer` to print the partially analyzed plan in addition to the user friendly error message, in order to aid debugging failing tests. In doing so, I ran into a conflict with the various ways that we bring a SQLContext into the tests. Depending on the trait we refer to the current context as `sqlContext`, `_sqlContext`, `ctx` or `hiveContext` with access modifiers `public`, `protected` and `private` depending on the defining class. I propose we refactor as follows: 1. All tests should only refer to a `protected sqlContext` when testing general features, and `protected hiveContext` when it is a method that only exists on a `HiveContext`. 2. All tests should only import `testImplicits._` (i.e., don't import `TestHive.implicits._`) Author: Wenchen Fan <cloud0fan@outlook.com> Closes #8584 from cloud-fan/cleanupTests.
kiszk
pushed a commit
to kiszk/spark-gpu
that referenced
this pull request
Dec 26, 2015
…ils to analyze This PR takes over apache/spark#8389. This PR improves `checkAnswer` to print the partially analyzed plan in addition to the user friendly error message, in order to aid debugging failing tests. In doing so, I ran into a conflict with the various ways that we bring a SQLContext into the tests. Depending on the trait we refer to the current context as `sqlContext`, `_sqlContext`, `ctx` or `hiveContext` with access modifiers `public`, `protected` and `private` depending on the defining class. I propose we refactor as follows: 1. All tests should only refer to a `protected sqlContext` when testing general features, and `protected hiveContext` when it is a method that only exists on a `HiveContext`. 2. All tests should only import `testImplicits._` (i.e., don't import `TestHive.implicits._`) Author: Wenchen Fan <cloud0fan@outlook.com> Closes #8584 from cloud-fan/cleanupTests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
checkAnswerto print the partially analyzed plan in addition to the user friendly error message, in order to aid debugging failing tests.In doing so, I ran into a conflict with the various ways that we bring a SQLContext into the tests. Depending on the trait we refer to the current context as
sqlContext,_sqlContext,ctxorhiveContextwith access modifierspublic,protectedandprivatedepending on the defining class.I propose we refactor as follows:
protected sqlContextwhen testing general features, andprotected hiveContextwhen it is a method that only exists on aHiveContext.testImplicits._(i.e., don'timport TestHive.implicits._)I made a pretty good crack at implementing the above, though there may be other outstanding locations. I suggest we address these in a follow up due to the likely hood of conflicts.