Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-9786][Streaming][Kafka] fix backpressure so it works with defa… #8413

Closed
wants to merge 1 commit into from
Closed

[SPARK-9786][Streaming][Kafka] fix backpressure so it works with defa… #8413

wants to merge 1 commit into from

Conversation

koeninger
Copy link
Contributor

…ult maxRatePerPartition setting of 0

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41519 has finished for PR 8413 at commit 2664626.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Aug 25, 2015

@koeninger Thank you very very much for debugging and fixing this.
@dragos This was a bug inadvertently introduced in earlier PR.

I am merging this to master and 1.5.

asfgit pushed a commit that referenced this pull request Aug 25, 2015
@koeninger @tdas
[SPARK-9786] [STREAMING] [KAFKA] fix backpressure so it works with defa…
88991dc 
…ult maxRatePerPartition setting of 0

Author: cody koeninger <cody@koeninger.org>

Closes #8413 from koeninger/backpressure-testing-master.

(cherry picked from commit d9c25de)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in d9c25de Aug 25, 2015
@dragos
Copy link
Contributor

dragos commented Aug 25, 2015

The rate limiter is using Long.MaxValue, while this one uses 0 as a default. They should both use the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@koeninger @SparkQA @tdas @dragos