[SPARK-10215] [SQL] Fix precision of division (follow the rule in Hive) #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #41526 has finished for PR 8415 at commit
|
|
I've tested with some corner case, it works for me. LGTM, except the unit test itself need to update with the new |
|
Test build #41545 has finished for PR 8415 at commit
|
| if (diff > 0) { | ||
| decDig -= diff / 2 + 1 | ||
| intDig = DecimalType.MAX_SCALE - decDig | ||
| DecimalType.bounded(intDig + decDig, decDig) |
There was a problem hiding this comment.
This line is not used. I will remove it when I merge the pr.
|
LGTM. Merging to master and branch 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2015
Follow the rule in Hive for decimal division. see https://github.com/apache/hive/blob/ac755ebe26361a4647d53db2a28500f71697b276/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java#L113 cc chenghao-intel Author: Davies Liu <davies@databricks.com> Closes #8415 from davies/decimal_div2. (cherry picked from commit 7467b52) Signed-off-by: Yin Huai <yhuai@databricks.com>
| intDig = DecimalType.MAX_SCALE - decDig | ||
| DecimalType.bounded(intDig + decDig, decDig) | ||
| } | ||
| val resultType = DecimalType.bounded(intDig + decDig, decDig) | ||
| val widerType = widerDecimalType(p1, s1, p2, s2) |
There was a problem hiding this comment.
is the resultType always tighter than widerType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the rule in Hive for decimal division. see https://github.com/apache/hive/blob/ac755ebe26361a4647d53db2a28500f71697b276/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java#L113
cc @chenghao-intel