[SPARK-9964] [PySpark] [SQL] PySpark DataFrameReader accept RDD of String for JSON #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #41583 has finished for PR 8444 at commit
|
|
Test build #41589 has finished for PR 8444 at commit
|
|
I don't think we should rename the name of the parameter since it could break compatibility. How about just changing the description? |
|
Test build #41611 has finished for PR 8444 at commit
|
| elif isinstance(path, RDD): | ||
| return self._df(self._jreader.json(path._jrdd)) | ||
| else: | ||
| raise Exception("path can be only string or RDD") |
There was a problem hiding this comment.
This should be https://docs.python.org/2/library/exceptions.html#exceptions.TypeError I think.
cc @davies
|
Test build #41668 has finished for PR 8444 at commit
|
|
Thanks - I've merged this in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySpark DataFrameReader should could accept an RDD of Strings (like the Scala version does) for JSON, rather than only taking a path.
If this PR is merged, it should be duplicated to cover the other input types (not just JSON).