Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10305] [SQL] fix create DataFrame from Python class #8470

Closed
wants to merge 1 commit into from
Closed

[SPARK-10305] [SQL] fix create DataFrame from Python class #8470

wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Aug 26, 2015

@SparkQA
Copy link

SparkQA commented Aug 26, 2015

Test build #41653 has finished for PR 8470 at commit 67d1bf4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Rating @Since("0.8.0") (
    • class MatrixFactorizationModel @Since("0.8.0") (

@jkbradley
Copy link
Member

LGTM, though I'm still waiting for it to compile locally for testing my use case.

@davies
Copy link
Contributor Author

davies commented Aug 26, 2015

@jkbradley one hint is that you do need to assembly to test python changes :)

@jkbradley
Copy link
Member

Oops, too late : /

@jkbradley
Copy link
Member

It works! LGTM

asfgit pushed a commit that referenced this pull request Aug 26, 2015
@davies
[SPARK-10305] [SQL] fix create DataFrame from Python class
0bdb800 
cc jkbradley

Author: Davies Liu <davies@databricks.com>

Closes #8470 from davies/fix_create_df.

(cherry picked from commit d41d6c4)
Signed-off-by: Davies Liu <davies.liu@gmail.com>
@davies
Copy link
Contributor Author

davies commented Aug 26, 2015

Merged into master and 1.5 branch.

@asfgit asfgit closed this in d41d6c4 Aug 26, 2015
@jkbradley
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@davies @SparkQA @jkbradley