Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor][SparkR] Fix some validation problems in SparkR #8474

Closed
wants to merge 1 commit into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Aug 27, 2015

Getting rid of some validation problems in SparkR
#7883

cc @shivaram

inst/tests/test_Serde.R:26:1: style: Trailing whitespace is superfluous.

^~
inst/tests/test_Serde.R:34:1: style: Trailing whitespace is superfluous.

^~
inst/tests/test_Serde.R:37:38: style: Trailing whitespace is superfluous.
  expect_equal(class(x), "character")
                                     ^~
inst/tests/test_Serde.R:50:1: style: Trailing whitespace is superfluous.

^~
inst/tests/test_Serde.R:55:1: style: Trailing whitespace is superfluous.

^~
inst/tests/test_Serde.R:60:1: style: Trailing whitespace is superfluous.

^~
inst/tests/test_sparkSQL.R:611:1: style: Trailing whitespace is superfluous.

^~
R/DataFrame.R:664:1: style: Trailing whitespace is superfluous.

^~~~~~~~~~~~~~
R/DataFrame.R:670:55: style: Trailing whitespace is superfluous.
                df <- data.frame(row.names = 1 : nrow)
                                                      ^~~~~~~~~~~~~~~~
R/DataFrame.R:672:1: style: Trailing whitespace is superfluous.

^~~~~~~~~~~~~~
R/DataFrame.R:686:49: style: Trailing whitespace is superfluous.
                    df[[names[colIndex]]] <- vec
                                                ^~~~~~~~~~~~~~~~~~

@shivaram
Copy link
Contributor

LGTM. Will merge once jenkins passes

@SparkQA
Copy link

SparkQA commented Aug 27, 2015

Test build #41660 has finished for PR 8474 at commit e70df5d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Rating @Since("0.8.0") (
    • class MatrixFactorizationModel @Since("0.8.0") (

@shivaram
Copy link
Contributor

Merging this

@shivaram
Copy link
Contributor

BTW I think these errors were caused by the SerDe change which is not in branch-1.5, so I only merged this to master

@asfgit asfgit closed this in 773ca03 Aug 27, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 27, 2015

Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants