[SPARKR] [SPARK-10328] Fix generic for na.omit #8495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yu-iskw |
|
@yu-iskw I also found a minor bug in lint-r that I just fixed. Please let me know if that is good. With this change lint-r passes on my machine |
|
@shivaram All right. I am checking this on my local machine. Please give me some minutes. |
| @@ -413,7 +413,7 @@ setGeneric("dropna", | |||
| #' @rdname nafunctions | |||
| #' @export | |||
| setGeneric("na.omit", | |||
There was a problem hiding this comment.
I'm just testing if we need this generic or not.
Add tests to check `na.omit` on a DataFrame
|
LGTM |
|
Cool - lintr checks also seem to be passing now. I'll merge this once tests pass |
|
Test build #41722 has finished for PR 8495 at commit
|
|
Test build #41724 has finished for PR 8495 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 28, 2015
S3 function is at https://stat.ethz.ch/R-manual/R-patched/library/stats/html/na.fail.html Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Author: Shivaram Venkataraman <shivaram.venkataraman@gmail.com> Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com> Closes #8495 from shivaram/na-omit-fix. (cherry picked from commit 2f99c37) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 function is at https://stat.ethz.ch/R-manual/R-patched/library/stats/html/na.fail.html