Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10336][example] fix not being able to set intercept in LR example #8510

Closed
wants to merge 1 commit into from

Conversation

coderxiang
Copy link
Contributor

fitIntercept is a command line option but not set in the main program.

@dbtsai

@coderxiang coderxiang changed the title fix not being able to set intercept in LR example [SPARK-10336][example] fix not being able to set intercept in LR example Aug 28, 2015
@dbtsai
Copy link
Member

dbtsai commented Aug 28, 2015

LGTM. By the way, we add intercept option in LiR recently, can you add it to the example code? Thanks.

@coderxiang
Copy link
Contributor Author

@dbtsai yeah notice that recently. Will test it on some data set and may do that in another pr.

@dbtsai
Copy link
Member

dbtsai commented Aug 28, 2015

Also disable standerizarion feature :)

@coderxiang
Copy link
Contributor Author

@dbtsai how about you create another jira and list down the things to be added?

@SparkQA
Copy link

SparkQA commented Aug 28, 2015

Test build #41755 has finished for PR 8510 at commit 57c9b7d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KMeans @Since("1.5.0") (

@dbtsai
Copy link
Member

dbtsai commented Aug 28, 2015

You can create the jira yourself.

asfgit pushed a commit that referenced this pull request Aug 28, 2015
`fitIntercept` is a command line option but not set in the main program.

dbtsai

Author: Shuo Xiang <sxiang@pinterest.com>

Closes #8510 from coderxiang/intercept and squashes the following commits:

57c9b7d [Shuo Xiang] fix not being able to set intercept in LR example

(cherry picked from commit 4572321)
Signed-off-by: DB Tsai <dbt@netflix.com>
@coderxiang
Copy link
Contributor Author

sure, I was thinking maybe you have a list in your mind :)

@dbtsai
Copy link
Member

dbtsai commented Aug 28, 2015

Thanks. Merged into branch 1.5, and master.

@asfgit asfgit closed this in 4572321 Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants