[SPARK-10344][SQL] Add tests for extraStrategies #8516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmbrus
force-pushed
the
extraStrategiesTests
branch
from
696abba
to
4a7c9ba
Compare
| @@ -23,7 +23,7 @@ import org.apache.spark.sql.{ColumnName, SQLContext} | |||
| /** | |||
| * Helper trait for SQL test suites where all tests share a single [[TestSQLContext]]. | |||
| */ | |||
| private[sql] trait SharedSQLContext extends SQLTestUtils { | |||
| trait SharedSQLContext extends SQLTestUtils { | |||
There was a problem hiding this comment.
this is already in the test jar... we we don't really ned to restrict visibility.
|
Test build #41774 has finished for PR 8516 at commit
|
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2015
Actually using this API requires access to a lot of classes that we might make private by accident. I've added some tests to prevent this. Author: Michael Armbrust <michael@databricks.com> Closes #8516 from marmbrus/extraStrategiesTests. (cherry picked from commit 5c3d16a) Signed-off-by: Yin Huai <yhuai@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually using this API requires access to a lot of classes that we might make private by accident. I've added some tests to prevent this.