[SPARK-10331] [MLLIB] Update example code in ml-guide #8518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengxr
changed the title
|
Test build #41782 has finished for PR 8518 at commit
|
| (0.0, Vectors.dense(2.0, 1.0, -1.0)), | ||
| (0.0, Vectors.dense(2.0, 1.3, 1.0)), | ||
| (1.0, Vectors.dense(0.0, 1.2, -0.5)) | ||
| )).toDF("label", "features") |
There was a problem hiding this comment.
+1 to switching from reflections-based schema inference into explicitly naming columns; should we consider deprecating LabeledPoint since a big use case is schema inference?
There was a problem hiding this comment.
LabeledPoint is used by many spark.mllib APIs.
|
Made first pass |
asfgit
pushed a commit
that referenced
this pull request
Aug 30, 2015
* The example code was added in 1.2, before `createDataFrame`. This PR switches to `createDataFrame`. Java code still uses JavaBean. * assume `sqlContext` is available * fix some minor issues from previous code review jkbradley srowen feynmanliang Author: Xiangrui Meng <meng@databricks.com> Closes #8518 from mengxr/SPARK-10331. (cherry picked from commit ca69fc8) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Test build #41798 has finished for PR 8518 at commit
|
|
Test build #41799 has finished for PR 8518 at commit
|
|
Test build #41800 has finished for PR 8518 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createDataFrame. This PR switches tocreateDataFrame. Java code still uses JavaBean.sqlContextis available@jkbradley @srowen @feynmanliang