[SPARK-10400] [SQL] Renames SQLConf.PARQUET_FOLLOW_PARQUET_FORMAT_SPEC #8566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened #8568 for the same purpose but against branch-1.5. |
|
This PR was originally part of the closed PR #7679, which aimed to refactor Parquet write path for better interoperability. I put too many things into that one and decided to split it into several smaller ones to ease code review. |
|
Test build #41917 has finished for PR 8566 at commit
|
liancheng
force-pushed
the
spark-10400/deprecate-follow-parquet-format-spec
branch
from
b3f7877
to
85bbfde
Compare
|
Test build #42413 has finished for PR 8566 at commit
|
|
retest this please |
|
Test build #43161 has finished for PR 8566 at commit
|
|
LGTM. Merging to master. |
liancheng
restored the
spark-10400/deprecate-follow-parquet-format-spec
branch
asfgit
pushed a commit
that referenced
this pull request
Dec 26, 2017
## What changes were proposed in this pull request? Some improvements: 1. Point out we are using both Spark SQ native syntax and HQL syntax in the example 2. Avoid using the same table name with temp view, to not confuse users. 3. Create the external hive table with a directory that already has data, which is a more common use case. 4. Remove the usage of `spark.sql.parquet.writeLegacyFormat`. This config was introduced by #8566 and has nothing to do with Hive. 5. Remove `repartition` and `coalesce` example. These 2 are not Hive specific, we should put them in a different example file. BTW they can't accurately control the number of output files, `spark.sql.files.maxRecordsPerFile` also controls it. ## How was this patch tested? N/A Author: Wenchen Fan <wenchen@databricks.com> Closes #20081 from cloud-fan/minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced SQL option
spark.sql.parquet.followParquetFormatSpecwhile working on implementing Parquet backwards-compatibility rules in SPARK-6777. It indicates whether we should use legacy Parquet format adopted by Spark 1.4 and prior versions or the standard format defined in parquet-format spec to write Parquet files.This option defaults to
falseand is marked as a non-public option (isPublic = false) because we haven't finished refactored Parquet write path. The problem is, the name of this option is somewhat confusing, because it's not super intuitive why we shouldn't follow the spec. Would be nice to rename it tospark.sql.parquet.writeLegacyFormat, and invert its default value (the two option names have opposite meanings).Although this option is private in 1.5, we'll make it public in 1.6 after refactoring Parquet write path. So that users can decide whether to write Parquet files in standard format or legacy format.