Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-9992][SPARK-9994][SPARK-9998][SQL]Implement the local TopK, sample and intersect operators #8573

Closed
wants to merge 5 commits into from
Closed

[SPARK-9992][SPARK-9994][SPARK-9998][SQL]Implement the local TopK, sample and intersect operators #8573

wants to merge 5 commits into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Sep 2, 2015

This PR is in conflict with #8535. I will update this one when #8535 gets merged.

@SparkQA
Copy link

SparkQA commented Sep 2, 2015

Test build #41933 has finished for PR 8573 at commit 4ccca2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class IntersectNode(left: LocalNode, right: LocalNode) extends BinaryLocalNode
    • abstract class BinaryLocalNode extends LocalNode
    • case class SampleNode(
    • case class TakeOrderedAndProjectNode(

@zsxwing zsxwing mentioned this pull request Sep 7, 2015
Closed
andrewor14
andrewor14 reviewed Sep 10, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LocalNode.scala
@@ -73,6 +73,30 @@ abstract class LocalNode extends TreeNode[LocalNode] {
}
result
}

def toIterator: Iterator[InternalRow] = new Iterator[InternalRow] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, looks like you already implemented this here :)

@andrewor14
Copy link
Contributor

Hey @zsxwing this looks good. Once you rebase and address the comments I'll merge it.

@SparkQA
Copy link

SparkQA commented Sep 11, 2015

Test build #42326 has finished for PR 8573 at commit a3270b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class IntersectNode(conf: SQLConf, left: LocalNode, right: LocalNode)
    • case class SampleNode(
    • case class TakeOrderedAndProjectNode(

@andrewor14
Copy link
Contributor

LGTM merging into master!

@asfgit asfgit closed this in e626ac5 Sep 11, 2015
@zsxwing zsxwing deleted the more-local-operators branch September 12, 2015 13:20
asfgit pushed a commit that referenced this pull request Sep 14, 2015
@zsxwing
[SPARK-9996] [SPARK-9997] [SQL] Add local expand and NestedLoopJoin o…
217e496 
…perators

This PR is in conflict with #8535 and #8573. Will update this one when they are merged.

Author: zsxwing <zsxwing@gmail.com>

Closes #8642 from zsxwing/expand-nest-join.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zsxwing @SparkQA @andrewor14