[SPARK-10422] [SQL] String column in InMemoryColumnarCache needs to override clone method #8578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Test build #41944 has finished for PR 8578 at commit
|
| ctx.range(1, 30000).selectExpr("id % 500 as id").rdd.map(id => Tuple1(s"str_$id")).toDF("i") | ||
| val cached = df.cache() | ||
| // count triggers the caching action. It should not throw. | ||
| cached.count() |
There was a problem hiding this comment.
Should we check the results?
|
|
||
| test("SPARK-10422: String column in InMemoryColumnarCache needs to override clone method") { | ||
| val df = | ||
| ctx.range(1, 100).selectExpr("id % 10 as id").rdd.map(id => Tuple1(s"str_$id")).toDF("i") |
There was a problem hiding this comment.
I reduced the number of rows to make this test faster. I also checked that it did fail without the fix.
|
Test build #1715 has finished for PR 8578 at commit
|
|
Test build #41952 has finished for PR 8578 at commit
|
|
Test build #1716 has finished for PR 8578 at commit
|
|
LGTM, merging this into master 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Sep 3, 2015
…verride clone method https://issues.apache.org/jira/browse/SPARK-10422 Author: Yin Huai <yhuai@databricks.com> Closes #8578 from yhuai/SPARK-10422. (cherry picked from commit 03f3e91) Signed-off-by: Davies Liu <davies.liu@gmail.com>
tianyi
added a commit
to growingio/spark
that referenced
this pull request
Sep 18, 2015
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
…verride clone method https://issues.apache.org/jira/browse/SPARK-10422 Author: Yin Huai <yhuai@databricks.com> Closes apache#8578 from yhuai/SPARK-10422. (cherry picked from commit 03f3e91) Signed-off-by: Davies Liu <davies.liu@gmail.com> (cherry picked from commit 2fce5d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-10422