-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10013][ML][JAVA][TEST] remove java assert from java unit tests #8607
[SPARK-10013][ML][JAVA][TEST] remove java assert from java unit tests #8607
Conversation
… assertEquals & assertTrue
…d matching the jUnit API
cc @jkbradley as the source of the JIRA |
Test build #42029 has finished for PR 8607 at commit
|
Test build #42030 has finished for PR 8607 at commit
|
@@ -36,6 +36,12 @@ | |||
</properties> | |||
|
|||
<dependencies> | |||
<!-- Added for sbt issue expected to be evicted, do not commit --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh fnur sorry, got mixed in, will take it out.
LGTM - except the build file. |
Test build #42048 has finished for PR 8607 at commit
|
I've merged this. |
Post-hoc +1 -- this was another thing I wanted to fix about the Java suite tests. |
From Jira: We should use assertTrue, etc. instead to make sure the asserts are not ignored in tests.