Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10013][ML][JAVA][TEST] remove java assert from java unit tests #8607

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Sep 4, 2015

From Jira: We should use assertTrue, etc. instead to make sure the asserts are not ignored in tests.

@holdenk
Copy link
Contributor Author

holdenk commented Sep 4, 2015

cc @jkbradley as the source of the JIRA

@holdenk holdenk changed the title [SPARK-10013][ML][JAVA][TEST][WIP] remove java assert from java unit tests [SPARK-10013][ML][JAVA][TEST] remove java assert from java unit tests Sep 4, 2015
@SparkQA
Copy link

SparkQA commented Sep 5, 2015

Test build #42029 has finished for PR 8607 at commit b3777fb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 5, 2015

Test build #42030 has finished for PR 8607 at commit 83544e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class DCT(JavaTransformer, HasInputCol, HasOutputCol):
    • class SQLTransformer(JavaTransformer):
    • class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):

@@ -36,6 +36,12 @@
</properties>

<dependencies>
<!-- Added for sbt issue expected to be evicted, do not commit -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh fnur sorry, got mixed in, will take it out.

@rxin
Copy link
Contributor

rxin commented Sep 5, 2015

LGTM - except the build file.

@SparkQA
Copy link

SparkQA commented Sep 5, 2015

Test build #42048 has finished for PR 8607 at commit 869b20d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Sep 5, 2015

I've merged this.

@asfgit asfgit closed this in 871764c Sep 5, 2015
@srowen
Copy link
Member

srowen commented Sep 5, 2015

Post-hoc +1 -- this was another thing I wanted to fix about the Java suite tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants