[SPARK-10461][SQL] make sure input.primitive is always variable name not code at GenerateUnsafeProjection
#8613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(sorry wrong pull request) |
|
Test build #42043 has finished for PR 8613 at commit
|
|
Test build #42051 has finished for PR 8613 at commit
|
|
LGTM, merging this into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate unsafe code inside
createCodeForXXX, we always assign theinput.primitiveto a temp variable in caseinput.primitiveis expression code.This PR did some refactor to make sure
input.primitiveis always variable name, and some other typo and style fixes.