[SPARK-6740][SQL] correctly parse NOT operator with comparison operations #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #42056 has finished for PR 8617 at commit
|
|
retest this please |
|
cc @marmbrus |
|
Test build #42871 has finished for PR 8617 at commit
|
|
Test build #42918 has finished for PR 8617 at commit
|
|
retest this please. |
|
Test build #43210 has finished for PR 8617 at commit
|
| notExpression * (AND ^^^ { (e1: Expression, e2: Expression) => And(e1, e2) }) | ||
|
|
||
| protected lazy val notExpression: Parser[Expression] = | ||
| NOT.? ~ comparisonExpression ^^ { case not ~ e => not.map(_ => Not(e)).getOrElse(e) } |
|
LGTM, will rename it while merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't parse
NOToperator with comparison operations likeSELECT NOT TRUE > TRUE, this PR fixed it.Takes over #6326.