Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readability #8645

Closed
wants to merge 1 commit into from
Closed

[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readability #8645

wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 7, 2015

Test build #42102 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan changed the title [SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readablity [SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readability Sep 8, 2015
@JoshRosen
Copy link
Contributor

Jenkins, retest this please

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 18, 2015

Test build #43889 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

This seems like a low hanging fruit to merge. @davies @yhuai can you have a look?

@andrewor14
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Dec 15, 2015

Test build #47744 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Dec 15, 2015

Looks fine to merge.

@cloud-fan Was there any issue with the original code?

@cloud-fan
Copy link
Contributor Author

No, just to make it more readable.

@andrewor14
Copy link
Contributor

OK, merging into master 1.6 thanks

asfgit pushed a commit that referenced this pull request Dec 16, 2015
@cloud-fan
[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readabi…
fb08f7b 
…lity

Author: Wenchen Fan <cloud0fan@outlook.com>

Closes #8645 from cloud-fan/test.

(cherry picked from commit a89e8b6)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in a89e8b6 Dec 16, 2015
@cloud-fan cloud-fan deleted the test branch December 16, 2015 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@cloud-fan @SparkQA @JoshRosen @andrewor14 @yhuai