-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Added R to the list of languages with "high-level API" support in the… #8646
Conversation
I just added another commit which makes some spelling / grammar updates to the quick-start MD file. |
@@ -272,7 +272,7 @@ scalaVersion := "{{site.SCALA_VERSION}}" | |||
libraryDependencies += "org.apache.spark" %% "spark-core" % "{{site.SPARK_VERSION}}" | |||
{% endhighlight %} | |||
|
|||
For sbt to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt` | |||
For SBT to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt is lower-case. jar seems equally upper and lower case, so, fine to change but on the whole I tend to leave things like that. I think the other changes are OK but not sure I'd bother with things that aren't obviously wrong, like an Oxford comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've switched all usages of "SBT" back to "sbt". At one point in time, SBT stood for "Simple Build Tool," but I can't find any remaining evidence of that on their site, so I'm guessing they've moved away from that.
Although this is probably OK without a JIRA, that's exceptional. Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark first. In particular this isn't tagged as |
|
||
<div class="codetabs"> | ||
<div data-lang="scala" markdown="1"> | ||
|
||
We'll create a very simple Spark application in Scala. So simple, in fact, that it's | ||
We'll create a very simple Spark application in Scala--so simple, in fact, that it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough about R. This LGTM. I would have put spaces around this dash but it's too small to bother with.
Test build #1727 has finished for PR 8646 at commit
|
… main README.