-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10274][MLlib] Add @since annotation to pyspark.mllib.fpm #8665
Conversation
Test build #42191 has finished for PR 8665 at commit
|
Does |
@mengxr unfortunately, a class which inherits from
When I tried to add
|
It seems that it works well with a class which inherits from This is a test script for |
@davies do you have any good idea about the above issue? |
We should add |
@davies thank you for the comment. Just to be sure, we should add |
I think we should add that to the docstring of class, the class methods already had it, isn't it? |
Right. I understand
|
@mengxr could you review it? |
Test build #42230 has finished for PR 8665 at commit
|
@noel-smith I prefer two part version numbers (with a few exceptions), that's the way python standard libraries do, but we use three parts in Scala, @mengxr how do you think? |
We should use version numbers consistently between Python and Scala, and we do have a few APIs added in minor releases (DataFrames, some ML pipeline APIs). I would prefer using |
LGTM (using three parts version in MLlib, we could re-visit the SQL parts later) |
Sounds good - thanks for confirming - I'll reinstate the thre-part version numbers in my PRs. |
@@ -41,8 +41,11 @@ class FPGrowthModel(JavaModelWrapper): | |||
>>> model = FPGrowth.train(rdd, 0.6, 2) | |||
>>> sorted(model.freqItemsets().collect()) | |||
[FreqItemset(items=[u'a'], freq=4), FreqItemset(items=[u'c'], freq=3), ... | |||
|
|||
.. addedversion:: 1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be versionadded
. Try make html
under python/docs
. Please look for compile warnings and check generated html doc.
Test build #42528 has finished for PR 8665 at commit
|
@yu-iskw Could you also add |
Test build #42582 has finished for PR 8665 at commit
|
Merged into master. Thanks! |
No description provided.