-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-9990] [SQL] Local hash join follow-ups #8708
Conversation
Test build #42294 has finished for PR 8708 at commit
|
@@ -70,9 +70,14 @@ abstract class LocalNode(conf: SQLConf) extends TreeNode[LocalNode] with Logging | |||
def close(): Unit | |||
|
|||
/** | |||
* Returns the content through the [[Iterator]] interface. | |||
*/ | |||
final def asIterator: Iterator[InternalRow] = new LocalNodeIterator(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this on the critical path? If yes - it'd actually be faster to expose the LocalNodeIterator type since JIT can inline it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is called when a HashJoinNode
is opened. Will it make much of a difference?
LGTM. Thanks @andrewor14 |
Merged into master. |
LocalNodeIterator
behind theLocalNode#asIterator
method