Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10549] scala 2.11 spark on yarn with security - Repl doesn't work #8719

Closed
wants to merge 2 commits into from

Conversation

tgravescs
Copy link
Contributor

Make this lazy so that it can set the yarn mode before creating the securityManager.

@srowen
Copy link
Member

srowen commented Sep 11, 2015

That seems reasonable. 2.10 doesn't need similar treatment? (I haven't paid attention to the difference in a while; it may not.)

@SparkQA
Copy link

SparkQA commented Sep 11, 2015

Test build #42339 has finished for PR 8719 at commit 2094e94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Can you add a comment on why it needs to be lazy?

@tgravescs
Copy link
Contributor Author

added comment

@SparkQA
Copy link

SparkQA commented Sep 14, 2015

Test build #42428 has finished for PR 8719 at commit 2dc7fe2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Yeah echoing @srowen's comment, @tgravescs does this fix apply only to scala 2.11? If so, do you know what it was specifically about 2.11 that made a difference?

@tgravescs
Copy link
Contributor Author

sorry missed his comment. No 2.10 works just fine. The repl code for that is much different.

@andrewor14
Copy link
Contributor

I see. Merging into master and 1.5.1

asfgit pushed a commit that referenced this pull request Sep 14, 2015
Make this lazy so that it can set the yarn mode before creating the securityManager.

Author: Tom Graves <tgraves@yahoo-inc.com>
Author: Thomas Graves <tgraves@staydecay.corp.gq1.yahoo.com>

Closes #8719 from tgravescs/SPARK-10549.
@asfgit asfgit closed this in ffbbc2c Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants