[DOCS] Small fixes to Spark on Yarn doc #8762
Conversation
* a follow-up to 16b6d18 as `--num-executors` flag is not suppported. * links + formatting
| @@ -54,8 +54,8 @@ In `yarn-cluster` mode, the driver runs on a different machine than the client, | |||
|
|
|||
| # Preparations | |||
|
|
|||
| Running Spark-on-YARN requires a binary distribution of Spark which is built with YARN support. | |||
| Binary distributions can be downloaded from the Spark project website. | |||
| Running Spark on YARN requires a binary distribution of Spark which is built with YARN support. | |||
There was a problem hiding this comment.
I don't see the value in the other changes; these two lines seem OK but this is pretty trivial. Would you consider taking one big review of the docs, or at least a logical set of docs, and identify meaningful improvements, and make a JIRA covering small improvements to a lot of docs? I don't think it's worth many tiny PRs for mostly non-functional changes.
There was a problem hiding this comment.
What about lines 30 and 24? They are the most important with the others just amendments as I was reviewing the entire doc. The reason for the change was this change 16b6d18 where I learnt the command line's option is no longer supported and hence the change in the doc.
There was a problem hiding this comment.
Yes removing the arg is a good idea. Line 24 is just a formatting change... OK but it renders the same way. I'm not against merging some of these changes per se, just requesting maybe a different approach going forward.
There was a problem hiding this comment.
See http://people.apache.org/~pwendell/spark-nightly/spark-master-docs/latest/running-on-yarn.html and search for ./bin/spark-submit --class path.to.your.Class. It renders incorrectly since there's the indent + backticks that make the docs go awry. That's why I fixed that, too.
What do you propose as a different approach going forward? When I see a change without changes to the docs, what's the proper approach?
There was a problem hiding this comment.
I see, it renders in code font already just not in the code box format. OK that seems fine. I think it's OK to merge this.
I'm referring to piecemeal edits since you've made a number of tiny PRs without a JIRA. It would be more efficient to have a review of whole logical sections of docs, and focus on small but not trivial changes in one PR. You'll probably end up spotting some broader opportunities to make docs consistent. Yes several of these changes here end up being good small fixes.
|
Test build #1759 has finished for PR 8762 at commit
|
--num-executorsflag is not suppported.