New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11114] [PYSPARK] add getOrCreate for SparkContext/SQLContext in Python #9122

Closed

davies wants to merge 3 commits into apache:master from davies:py_create

Contributor

davies commented Oct 14, 2015

Also added SQLContext.newSession()


          add getOrCreate for SparkContext/SQLContext in Python

e5a2437

SparkQA commented Oct 14, 2015

Test build #43741 has finished for PR 9122 at commit e5a2437.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA commented Oct 14, 2015

Test build #1902 has finished for PR 9122 at commit e5a2437.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.


          fix test

f92cd43

SparkQA commented Oct 15, 2015

Test build #43755 has finished for PR 9122 at commit f92cd43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

andrewor14 reviewed

View reviewed changes

python/pyspark/context.py

+                      :param conf: SparkConf (optional)
+                      """
+                      if SparkContext._active_spark_context is None:

Contributor

andrewor14 Oct 16, 2015

don't you need to hold SparkContext._lock when you check for this?


          address comment

f272ddc

SparkQA commented Oct 16, 2015

Test build #43847 has finished for PR 9122 at commit f272ddc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Contributor

andrewor14 commented Oct 19, 2015

LGTM merging into master. Thanks @davies!

asfgit closed this in

232d7f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment