New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11194] [SQL] Use MutableURLClassLoader for the classLoader in IsolatedClientLoader. #9170
Conversation
Test build #43938 has finished for PR 9170 at commit
|
test this please |
hmm. When we close a session in thrift server, we will close the session state, which internally closes the class loader (the code starts from https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala#L77 and @liancheng For our thrift server, do we need to use |
https://docs.oracle.com/javase/8/docs/technotes/guides/net/ClassLoader.html is an article about closing a classloader. Looks like |
} | ||
} else { | ||
baseClassLoader | ||
new MutableURLClassLoader(Array.empty, isolatedClassLoader) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One hacky way to workaround the problem is that we have a no-op close
method for this classloader.
Test build #44208 has finished for PR 9170 at commit
|
LGTM |
Thanks for reviewing! I am merging it to master. |
https://issues.apache.org/jira/browse/SPARK-11194