[SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example #9353

rishabhbhardwaj · 2015-10-29T11:58:35Z

I have made the required changes in mllib-naive-bayes.md/mllib-isotonic-regression.md and also verified them.
Kindle Review it.

…b-isotonic-regression.md using include_example

mengxr · 2015-10-29T15:43:37Z

ok to test

mengxr · 2015-10-29T15:43:50Z

@yinxusen Could you help review this PR?

mengxr · 2015-10-29T15:44:40Z

examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java

+
+public class JavaIsotonicRegressionExample {
+
+    public static void main(String[] args) {


Please use 2-space indentation. Check https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide.

mengxr · 2015-10-29T15:45:54Z

@rishabhbhardwaj Thanks for working on this! I saw some code style issues in your code. You might want to check the Spark Code Style guide first at https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide.

SparkQA · 2015-10-29T15:57:35Z

Test build #44607 has finished for PR 9353 at commit f40fcc1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

rishabhbhardwaj · 2015-10-29T17:53:27Z

@mengxr Thanks for your comments.I have corrected the code style issues and locally ran the style checks and they passed.

rishabhbhardwaj · 2015-10-29T17:55:41Z

Jenkins test this please

SparkQA · 2015-10-29T18:24:46Z

Test build #44617 has finished for PR 9353 at commit d9c143e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

yinxusen · 2015-10-29T18:43:52Z

@rishabhbhardwaj Please update the title with more specific infomation.

yinxusen · 2015-10-29T18:46:25Z

examples/src/main/python/mllib/isotonic_regression_example.py

+
+"""
+Isotonic Regression Example.
+


remove the empty line

SparkQA · 2015-10-29T18:57:13Z

Test build #44620 has finished for PR 9353 at commit 11804bb.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

SparkQA · 2015-10-29T19:07:23Z

Test build #44623 has finished for PR 9353 at commit 256fb3a.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

SparkQA · 2015-10-29T19:40:34Z

Test build #44628 has finished for PR 9353 at commit d1f5afd.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

rishabhbhardwaj · 2015-10-29T19:42:55Z

@yinxusen Thanks for your comments.

yinxusen · 2015-10-30T01:08:32Z

docs/mllib-isotonic-regression.md

-{% highlight python %}
-import math
-from pyspark.mllib.regression import IsotonicRegression, IsotonicRegressionModel
+{% include_example python/mllib/isotonic_regression_example.py %}



empty line is no need, pls remove it.

yinxusen · 2015-10-30T01:11:11Z

@mengxr This pr LGTM, except for some blank lines.

SparkQA · 2015-10-30T02:09:59Z

Test build #44653 has finished for PR 9353 at commit b4a64a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

rishabhbhardwaj · 2015-10-30T02:15:15Z

@yinxusen I have removed the empty lines.Thanks for the comments.

mengxr · 2015-10-30T06:09:19Z

examples/src/main/java/org/apache/spark/examples/mllib/JavaIsotonicRegressionExample.java

+import org.apache.spark.api.java.function.PairFunction;
+import org.apache.spark.api.java.JavaDoubleRDD;
+import org.apache.spark.api.java.JavaPairRDD;
+// $example off$


This is not necessary. See discussion at https://issues.apache.org/jira/browse/SPARK-11337. You can include all imports in a single block or move unused imports to a separate group. We only need to keep imports ordered in each group. Use empty lines to separate import groups.

SparkQA · 2015-10-30T07:28:15Z

Test build #44668 has finished for PR 9353 at commit 331eab2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n * public class JavaIsotonicRegressionExample\n * public class JavaNaiveBayesExample\n

rishabhbhardwaj · 2015-10-30T07:34:01Z

@mengxr Thanks for your comments and patience.I have made the required changes.

rishabhbhardwaj added 5 commits October 19, 2015 12:12

[ SPARK-11180 ] [ SQL ] DataFrame.na.fill does not support Boolean Type

d152cb5

Merge remote-tracking branch 'upstream/master'

a53a20d

Merge remote-tracking branch 'upstream/master'

870cbb3

Merge remote-tracking branch 'upstream/master'

a21b0ed

[SPARK-11383][Docs] Replace example code in mllib-naive-bayes.md/mlli…

f40fcc1

…b-isotonic-regression.md using include_example

mengxr reviewed Oct 29, 2015
View reviewed changes

corrected code style issues

d9c143e

Ordering imports

11804bb

rishabhbhardwaj changed the title ~~[SPARK-11383][Docs] Replaced example code in mllib using include_example~~ [SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example Oct 29, 2015

yinxusen reviewed Oct 29, 2015
View reviewed changes

examples/src/main/python/mllib/isotonic_regression_example.py

"""

Isotonic Regression Example.

Copy link

Contributor

yinxusen Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty line

removing empty lines

256fb3a

correcting ordering of imports

073251b

python style check correction

d1f5afd

yinxusen reviewed Oct 30, 2015
View reviewed changes

removing empty lines

b4a64a2

mengxr reviewed Oct 30, 2015
View reviewed changes

Changes as per comments

331eab2

asfgit closed this in 2804674 Nov 2, 2015

rishabhbhardwaj deleted the SPARK-11383 branch November 28, 2015 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example #9353

[SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example #9353

rishabhbhardwaj commented Oct 29, 2015

mengxr commented Oct 29, 2015

mengxr commented Oct 29, 2015

mengxr Oct 29, 2015

mengxr commented Oct 29, 2015

SparkQA commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

SparkQA commented Oct 29, 2015

yinxusen commented Oct 29, 2015

yinxusen Oct 29, 2015

SparkQA commented Oct 29, 2015

SparkQA commented Oct 29, 2015

SparkQA commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

yinxusen Oct 30, 2015

yinxusen commented Oct 30, 2015

SparkQA commented Oct 30, 2015

rishabhbhardwaj commented Oct 30, 2015

mengxr Oct 30, 2015

SparkQA commented Oct 30, 2015

rishabhbhardwaj commented Oct 30, 2015


		public class JavaIsotonicRegressionExample {

		public static void main(String[] args) {

[SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example #9353

[SPARK-11383][Docs] Replaced example code in mllib-naive-bayes.md/mllib-isotonic-regression.md using include_example #9353

Conversation

rishabhbhardwaj commented Oct 29, 2015

mengxr commented Oct 29, 2015

mengxr commented Oct 29, 2015

mengxr Oct 29, 2015

Choose a reason for hiding this comment

mengxr commented Oct 29, 2015

SparkQA commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

SparkQA commented Oct 29, 2015

yinxusen commented Oct 29, 2015

yinxusen Oct 29, 2015

Choose a reason for hiding this comment

SparkQA commented Oct 29, 2015

SparkQA commented Oct 29, 2015

SparkQA commented Oct 29, 2015

rishabhbhardwaj commented Oct 29, 2015

yinxusen Oct 30, 2015

Choose a reason for hiding this comment

yinxusen commented Oct 30, 2015

SparkQA commented Oct 30, 2015

rishabhbhardwaj commented Oct 30, 2015

mengxr Oct 30, 2015

Choose a reason for hiding this comment

SparkQA commented Oct 30, 2015

rishabhbhardwaj commented Oct 30, 2015