Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11515][ML] QuantileDiscretizer should take random seed #9535

Closed
wants to merge 2 commits into from
Closed

[SPARK-11515][ML] QuantileDiscretizer should take random seed #9535

wants to merge 2 commits into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Nov 7, 2015

@SparkQA
Copy link

SparkQA commented Nov 7, 2015

Test build #45277 has finished for PR 9535 at commit bfabeb2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 15, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Dec 15, 2015

Test build #47692 has finished for PR 9535 at commit 888b0f0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 15, 2015

I have rebased this PR with master.

@thunterdb
Copy link
Contributor

@yu-iskw thanks for fixing this issue. It looks good to me, but can you please resolve the conflicts?

@jkbradley
Copy link
Member

@yu-iskw Apologies for the delay. We can get this merged now, once you can update it. Thank you!

@SparkQA
Copy link

SparkQA commented Jan 19, 2016

Test build #49683 has finished for PR 9535 at commit 604cd60.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

thunterdb
thunterdb reviewed Jan 19, 2016
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala
@@ -23,8 +23,8 @@ import org.apache.spark.Logging
import org.apache.spark.annotation.{Experimental, Since}
import org.apache.spark.ml._
import org.apache.spark.ml.attribute.NominalAttribute
import org.apache.spark.ml.param.shared.{HasSeed, HasInputCol, HasOutputCol}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yu-iskw you need to respect the lexicographic order for the imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out. I forgot running the lint script.

@SparkQA
Copy link

SparkQA commented Jan 20, 2016

Test build #49740 has finished for PR 9535 at commit c2ca9b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jan 20, 2016

@jkbradley I have rebased with master. Can you review it?

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Feb 10, 2016

@jkbradley ping

@asfgit asfgit closed this in 574571c Feb 11, 2016
@mengxr
Copy link
Contributor

mengxr commented Feb 11, 2016

LGTM. Merged into master. Thanks! @yu-iskw I created https://issues.apache.org/jira/browse/SPARK-13292 for the Python API and assigned to you.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Feb 11, 2016

Thank you for merging it. I will do the issue. Thanks!

asfgit pushed a commit that referenced this pull request Mar 4, 2016
@yu-iskw @srowen
[SPARK-11515][ML] QuantileDiscretizer should take random seed
5a27129 
cc jkbradley

Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com>

Closes #9535 from yu-iskw/SPARK-11515.

(cherry picked from commit 574571c)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@yu-iskw @SparkQA @thunterdb @jkbradley @mengxr