Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11552][DOCS][Replaced example code in ml-decision-tree.md using include_example] #9539

Closed
wants to merge 5 commits into from
Closed

[SPARK-11552][DOCS][Replaced example code in ml-decision-tree.md using include_example] #9539

wants to merge 5 commits into from

Conversation

agsachin
Copy link
Contributor

@agsachin agsachin commented Nov 7, 2015

I have tested it on my local, it is working fine, please review

yinxusen
yinxusen reviewed Nov 9, 2015
View reviewed changes
examples/src/main/java/org/apache/spark/examples/ml/JavaDecisionTreeClassificationExample.java
package org.apache.spark.examples.ml;

// $example on$

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this empty line

@agsachin
Copy link
Contributor Author

agsachin commented Nov 9, 2015

Thanks @yinxusen
I have removed all the empty lines

@yinxusen
Copy link
Contributor

yinxusen commented Nov 9, 2015

@mengxr LGTM

@mengxr
Copy link
Contributor

mengxr commented Nov 9, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Nov 9, 2015

test this please

@SparkQA
Copy link

SparkQA commented Nov 9, 2015

Test build #45418 has finished for PR 9539 at commit 8a24935.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaDecisionTreeClassificationExample\n * public class JavaDecisionTreeRegressionExample\n

@mengxr
Copy link
Contributor

mengxr commented Nov 9, 2015

Merged into master and branch-1.6. Thanks!

asfgit pushed a commit that referenced this pull request Nov 9, 2015
@agsachin @mengxr
[SPARK-11552][DOCS][Replaced example code in ml-decision-tree.md usin…
129cfab 
…g include_example]

I have tested it on my local, it is working fine, please review

Author: sachin aggarwal <different.sachin@gmail.com>

Closes #9539 from agsachin/SPARK-11552-real.

(cherry picked from commit 51d41e4)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 51d41e4 Nov 9, 2015
@agsachin agsachin deleted the SPARK-11552-real branch February 8, 2016 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@agsachin @yinxusen @mengxr @SparkQA