-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11549][Docs] Replace example code in mllib-evaluation-metrics.md using include_example #9689
Conversation
import org.apache.spark.SparkConf; | ||
import org.apache.spark.SparkContext; | ||
|
||
public class JavaBinaryClassification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better making these class names more concretely. I.e. JavaBinaryClassificatinMetricsExample
. And the same for the following classes.
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space line
@yinxusen Thanks for patiently pointing out the issues. I've fixed them. Please test it. |
Test build #46322 has finished for PR 9689 at commit
|
|
||
package org.apache.spark.examples.mllib | ||
|
||
// $example on$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove it, there are two $example on$
@mengxr LGTM except for some minor issues. |
Test build #46324 has finished for PR 9689 at commit
|
Merged into master and branch-1.6. Thanks! |
No description provided.