[SPARK-11745][SQL] Enable more JSON parsing options #9724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,22 +221,6 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with Logging with Serializ | |||
|
|
|||
| private[this] def isTesting: Boolean = sys.props.contains("spark.testing") | |||
|
|
|||
| protected def newProjection( | |||
| * <li>`allowSingleQuotes` (default `true`): allows single quotes in addition to double quotes | ||
| * </li> | ||
| * <li>`allowNumericLeadingZeros` (default `false`): allows leading zeros in numbers | ||
| * (e.g. 00012)</li> |
There was a problem hiding this comment.
I think we skipped it in the past because it had very little impact on performance, so in most cases it is better to just use 1.0... Maybe we should even deprecate that option.
|
Test build #2061 has finished for PR 9724 at commit
|
|
Test build #45972 has finished for PR 9724 at commit
|
|
Alright I've updated it. |
|
LGTM pending jenkins. |
|
Test build #45981 has finished for PR 9724 at commit
|
|
Thanks - I'm merging this in. |
asfgit
pushed a commit
that referenced
this pull request
Nov 16, 2015
This patch adds the following options to the JSON data source, for dealing with non-standard JSON files: * `allowComments` (default `false`): ignores Java/C++ style comment in JSON records * `allowUnquotedFieldNames` (default `false`): allows unquoted JSON field names * `allowSingleQuotes` (default `true`): allows single quotes in addition to double quotes * `allowNumericLeadingZeros` (default `false`): allows leading zeros in numbers (e.g. 00012) To avoid passing a lot of options throughout the json package, I introduced a new JSONOptions case class to define all JSON config options. Also updated documentation to explain these options. Scala  Python  Author: Reynold Xin <rxin@databricks.com> Closes #9724 from rxin/SPARK-11745. (cherry picked from commit 42de525) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the following options to the JSON data source, for dealing with non-standard JSON files:
allowComments(defaultfalse): ignores Java/C++ style comment in JSON recordsallowUnquotedFieldNames(defaultfalse): allows unquoted JSON field namesallowSingleQuotes(defaulttrue): allows single quotes in addition to double quotesallowNumericLeadingZeros(defaultfalse): allows leading zeros in numbers (e.g. 00012)To avoid passing a lot of options throughout the json package, I introduced a new JSONOptions case class to define all JSON config options.
Also updated documentation to explain these options.
Scala
Python