[SPARK-11755] [R] SparkR should export "predict" #9732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #45993 has finished for PR 9732 at commit
|
| @@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") }) | |||
| #' @export | |||
| setGeneric("glm") | |||
|
|
|||
| #' @rdname predict | |||
| #' @export | |||
| setGeneric("predict", function(object, newData) { standardGeneric("predict") }) | |||
There was a problem hiding this comment.
It may be better to keep the signature of "predict" to be same as that in R base.
setGeneric("predict", function(object, ...) { standardGeneric("predict") })
There was a problem hiding this comment.
Yeah we should follow the same signature
|
Test build #46087 has finished for PR 9732 at commit
|
|
LGTM |
1 similar comment
|
LGTM |
|
Merging this to master, branch-1.6 |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
The bug described at [SPARK-11755](https://issues.apache.org/jira/browse/SPARK-11755), after exporting ```predict``` we can both get the help information from the SparkR and base R package like the following: ```Java > help(predict) Help on topic ‘predict’ was found in the following packages: Package Library SparkR /Users/yanboliang/data/trunk2/spark/R/lib stats /Library/Frameworks/R.framework/Versions/3.2/Resources/library Choose one 1: Make predictions from a model {SparkR} 2: Model Predictions {stats} ``` Author: Yanbo Liang <ybliang8@gmail.com> Closes #9732 from yanboliang/spark-11755. (cherry picked from commit 8fb775b) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug described at SPARK-11755, after exporting
predictwe can both get the help information from the SparkR and base R package like the following: