[SPARK-11108][ML] OneHotEncoder should support other numeric types #9777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #46112 has finished for PR 9777 at commit
|
|
Test build #46111 has finished for PR 9777 at commit
|
| assert(x <= Int.MaxValue, | ||
| s"OneHotEncoder only supports up to ${Int.MaxValue} indices, but got $x") | ||
| assert(x >= 0.0 && x == x.toInt, | ||
| s"Values e column $inputColName must be indices, but got $x.") |
There was a problem hiding this comment.
I reverted this back to the original wording, "Values from column".
|
LGTM aside from that one typo |
|
Test build #52675 has finished for PR 9777 at commit
|
|
Test build #52680 has finished for PR 9777 at commit
|
|
Test build #52684 has finished for PR 9777 at commit
|
|
LGTM merged into master. Thanks! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
Adding support for other numeric types: * Integer * Short * Long * Float * Decimal Author: sethah <seth.hendrickson16@gmail.com> Closes apache#9777 from sethah/SPARK-11108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for other numeric types: