[SPARK-11792] [SQL] [FOLLOW-UP] Change SizeEstimation to KnownSizeEstimation and make estimatedSize return Long instead of Option[Long] #9813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn Long instead of Option[Long].
|
@davies how about this version? |
|
LGTM |
|
Test build #46219 has finished for PR 9813 at commit
|
|
Thanks! Merging to master and branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
…imation and make estimatedSize return Long instead of Option[Long] https://issues.apache.org/jira/browse/SPARK-11792 The main changes include: * Renaming `SizeEstimation` to `KnownSizeEstimation`. Hopefully this new name has more information. * Making `estimatedSize` return `Long` instead of `Option[Long]`. * In `UnsaveHashedRelation`, `estimatedSize` will delegate the work to `SizeEstimator` if we have not created a `BytesToBytesMap`. Since we will put `UnsaveHashedRelation` to `BlockManager`, it is generally good to let it provide a more accurate size estimation. Also, if we do not put `BytesToBytesMap` directly into `BlockerManager`, I feel it is not really necessary to make `BytesToBytesMap` extends `KnownSizeEstimation`. Author: Yin Huai <yhuai@databricks.com> Closes #9813 from yhuai/SPARK-11792-followup. (cherry picked from commit 6f99522) Signed-off-by: Yin Huai <yhuai@databricks.com>
srowen
pushed a commit
that referenced
this pull request
Nov 24, 2021
### What changes were proposed in this pull request? Followup #9813 ### Why are the changes needed? Fix scaladoc. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #34692 from pan3793/SPARK-11792. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-11792
The main changes include:
SizeEstimationtoKnownSizeEstimation. Hopefully this new name has more information.estimatedSizereturnLonginstead ofOption[Long].UnsaveHashedRelation,estimatedSizewill delegate the work toSizeEstimatorif we have not created aBytesToBytesMap.Since we will put
UnsaveHashedRelationtoBlockManager, it is generally good to let it provide a more accurate size estimation. Also, if we do not putBytesToBytesMapdirectly intoBlockerManager, I feel it is not really necessary to makeBytesToBytesMapextendsKnownSizeEstimation.