[SPARK-11925] [ML] [PySpark] Add PySpark missing methods for ml.feature during Spark 1.6 QA #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #46529 has finished for PR 9908 at commit
|
|
Test build #47512 has finished for PR 9908 at commit
|
|
ping @jkbradley |
| @@ -1009,26 +1029,34 @@ class RegexTokenizer(JavaTransformer, HasInputCol, HasOutputCol): | |||
| minTokenLength = Param(Params._dummy(), "minTokenLength", "minimum token length (>= 0)") | |||
| gaps = Param(Params._dummy(), "gaps", "whether regex splits on gaps (True) or matches tokens") | |||
| pattern = Param(Params._dummy(), "pattern", "regex pattern (Java dialect) used for tokenizing") | |||
| toLowercase = Param(Params._dummy(), "toLowercase", "whether to convert all characters to " + | |||
| "lowercase before tokenizing, default is true") | |||
There was a problem hiding this comment.
No need to state default in built-in doc
|
Looks good, just a few comments |
|
Test build #49456 has finished for PR 9908 at commit
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PySpark missing methods and params for ml.feature:
RegexTokenizershould support settingtoLowercase.MinMaxScalerModelshould support outputoriginalMinandoriginalMax.PCAModelshould support outputpc.