Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11975] [ML] Remove duplicate mllib example (DT/RF/GBT in Java/Python) #9954

Closed
wants to merge 2 commits into from

Conversation

yanboliang
Copy link
Contributor

Remove duplicate mllib example (DT/RF/GBT in Java/Python).
Since we have tutorial code for DT/RF/GBT classification/regression in Scala/Java/Python and example applications for DT/RF/GBT in Scala, so we mark these as duplicated and remove them.
@mengxr

@yanboliang yanboliang changed the title [SPARK-11975] [ML] Remove duplicate mllib example (DT/RF/GBT in Java) [SPARK-11975] [ML] Remove duplicate mllib example (DT/RF/GBT in Java/Python) Nov 25, 2015
@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46658 has finished for PR 9954 at commit 96a4527.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46659 has finished for PR 9954 at commit 416da6a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Just one comment: I have gotten feedback from some people about using these scripts, so we might get some complaints after removing them. That said, I'm OK with removing them since command-line tools are not the best way to use Spark.

@yanboliang
Copy link
Contributor Author

@jkbradley Users can use decision_tree_classification_example.py and decision_tree_regression_example.py instead to illustrate the usage of decision tree algorithm and model. I still keep the Scala example application (with command-line tools one) which has more complete input params. There is little difference between these two kinds of examples for Java/Python, so I think removing Java/Python ones is make sense.

@mengxr
Copy link
Contributor

mengxr commented Nov 30, 2015

LGTM. Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in de64b65 Nov 30, 2015
asfgit pushed a commit that referenced this pull request Nov 30, 2015
…ython)

Remove duplicate mllib example (DT/RF/GBT in Java/Python).
Since we have tutorial code for DT/RF/GBT classification/regression in Scala/Java/Python and example applications for DT/RF/GBT in Scala, so we mark these as duplicated and remove them.
mengxr

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #9954 from yanboliang/SPARK-11975.

(cherry picked from commit de64b65)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@yanboliang yanboliang deleted the SPARK-11975 branch May 5, 2016 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants