Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11978] [ML] Move dataset_example.py to examples/ml and rename to dataframe_example.py #9957

Closed
wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

Since Dataset has a new meaning in Spark 1.6, we should rename it to avoid confusion.
#9873 finished the work of Scala example, here we focus on the Python one.

Move dataset_example.py to examples/ml and rename to dataframe_example.py.
BTW, fix minor missing issues of #9873.
cc @mengxr

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46664 has finished for PR 9957 at commit 1d5932a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47514 has finished for PR 9957 at commit 1d5932a.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Dec 11, 2015

Test build #47581 has finished for PR 9957 at commit 1d5932a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Reviewing now

@jkbradley
Copy link
Member

I don't have any comments; it LGTM
I ran it locally, and it worked fine.

Merging with master and branch-1.6

Thanks for the PR!

@yanboliang
Copy link
Contributor Author

@jkbradley Would you mind to check the merging status of this PR? I did not found it merging into master. Thanks!

Sorry, maybe something wrong with github. But never mind, it succeed at last.

asfgit pushed a commit that referenced this pull request Dec 12, 2015
…o dataframe_example.py

Since ```Dataset``` has a new meaning in Spark 1.6, we should rename it to avoid confusion.
#9873 finished the work of Scala example, here we focus on the Python one.
Move dataset_example.py to ```examples/ml``` and rename to ```dataframe_example.py```.
BTW, fix minor missing issues of #9873.
cc mengxr

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #9957 from yanboliang/SPARK-11978.

(cherry picked from commit a0ff6d1)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in a0ff6d1 Dec 12, 2015
@yanboliang yanboliang deleted the SPARK-11978 branch December 12, 2015 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants