STORM-3148: Addressed review comments

apache · Jul 13, 2018 · bfb267e · bfb267e
1 parent 6301756
commit bfb267e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 35 deletions.
diff --git a/storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java b/storm-client/src/jvm/org/apache/storm/messaging/netty/StormClientHandler.java
@@ -50,6 +50,8 @@ public void channelRead(ChannelHandlerContext ctx, Object message) throws Except
                     try {
                         remoteBpStatus[bpTask].set(true);
                     } catch (ArrayIndexOutOfBoundsException e) {
+                        //Just in case we get something we are confused about
+                        // we can continue processing the rest of the tasks
                         LOG.error("BP index out of bounds {}", e);
                     }
                 }
@@ -59,6 +61,8 @@ public void channelRead(ChannelHandlerContext ctx, Object message) throws Except
                     try {
                         remoteBpStatus[bpTask].set(false);
                     } catch (ArrayIndexOutOfBoundsException e) {
+                        //Just in case we get something we are confused about
+                        // we can continue processing the rest of the tasks
                         LOG.error("BP index out of bounds {}", e);
                     }
                 }

diff --git a/storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java b/storm-client/test/jvm/org/apache/storm/messaging/netty/BackPressureStatusTest.java