STORM-1549: Add support for resetting tuple timeout from bolts via the OutputCollector #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e OutputCollector
|
Anyone have any feedback on this? |
|
@srdo Sorry I have been really behind on reviews. The code and the concept seem sound. I have not thought through all of the implications of this, but as of now I am +1 for this. The only real issue is that we need a pull request/feature to go into master before we can do something for 1.x-branch. |
|
Great. I'll make another PR when I've made these changes on master. Should I close this one? |
|
@srdo If you want to get the changes into 1.x keep this around. master and 1.x have diverged enough that it is not a simple sherry-pick any more for this part of the code. |
|
The test failure looks unrelated to this PR, was also happening on 1.x-branch https://travis-ci.org/apache/storm/jobs/115948898 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/STORM-1549.
Other than implementing tuple timeout reset, I made a minor change to assert-loop in integration_test.clj so it doesn't hang on failing tests. It should now fail the test after 10 seconds. I hope that's okay.