Tests - STORM-1235, STORM-1236, STORM-1237, STORM-1238, STORM-1249 #1200
Conversation
| @@ -287,13 +287,13 @@ | |||
| <artifactId>metrics-clojure</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
There was a problem hiding this comment.
hamcrest-core dependency is shaded inside the mockito-all and junit brings in another version of hamcrest-core which are incompatible. Excluding hamcrest-core from junit didn't work. This reordering worked. hamcrest-core dependency is needed by ThrowableNestedCauseMapper class.
There was a problem hiding this comment.
can you add thee above comment in the pom.xml
abhishekagarwal87
force-pushed
the
tests
branch
from
f12d7a9
to
368c75f
Compare
|
@revans2 can you take a look? Travis failure looks unrelated. |
|
@abhishekagarwal87 Can you file one JIRA for this and list out all the tests that fixed in the description. We shouldn't filing individual jira for each test. |
|
Thanks @harshach. Right now, we have one JIRA for each clojure file that is to be ported into Java. All the JIRA tasks have already been created. Do you want me to file a single JIRA and resolve others as duplicate? The tests, by the way, aren't strictly related to each other. |
abhishekagarwal87
force-pushed
the
tests
branch
from
368c75f
to
e05a916
Compare
|
@abhishekagarwal87 ok makes sense confused by the PR title. |
|
@revans2 ping |
|
@harshach - can you take a look at this PR? It's been pending for a while. Your comments have already been addressed. |
|
Can someone review this? |
|
Thank you @abhishekagarwal87 +1 |
|
+1 |
YSTORM-5367 fix setting of nimbus uptime
No description provided.