STORM-2111 [Storm SQL] support 'LIKE' and 'SIMILAR TO' #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsumer * SqlTridentConsumer contains StateFactory and StateUpdater which is needed to store tuples to State via batch * Apply the change to storm-sql-kafka * move out JsonScheme and JsonSerializer to runtime * it will be used from other external sql modules * add javadoc to ISqlTridentDataSource
* associate 'LIKE' and 'SIMILAR TO' to its implementation Calcite is providing * NOTE: SIMILAR TO takes SQL regex, not Java regex * add unit tests
|
Tests of storm-sql-core failed because of VM crashing. UT passes on my local dev. |
|
Closing this since STORM-2125 (#1714) covers this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This patch is on top of STORM-2089 in order to reduce any merge conflict and upmerging.
Reviewers may want to only take a look into 3e05056.
I also addressed some ExprCompiler's bug: doesn't wrap null as type in elvis operator which raises type mismatch.
Please review and comment. Thanks!