New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORM-2249: Make Distribution Scripts Put Examples to the Correct Locations #1831
STORM-2249: Make Distribution Scripts Put Examples to the Correct Locations #1831
Conversation
hmcl
commented
Dec 17, 2016
- Move all examples under STORM_HOME/examples/storm-COMPONENT-NAME-examples/COMPONENT-NAME-examples-x.y.x.jar
…ations - Move all examples under STORM_HOME/examples/storm-COMPONENT-NAME-examples/COMPONENT-NAME-examples-x.y.x.jar
2787d7e
to
397e3ce
Compare
@hmcl |
@HeartSaVioR I think it makes sense to have the shaded jars. It will be easier to run the code for the users who not familiar with storm packaging and gives insight into building a topology jar as well. |
@HeartSaVioR do you mean each README of each module should have a section on how to run the JAR, and the main for that JAR? I agree with that. Perhaps I could file a follow-up JIRA for that. |
Also could you check how big binary dist (tar.gz / zip) will be? It's already over 200MB so IMHO it would be better to reduce/restrict the size of binary dist. |
Before:
After:
Sorry but for me the final size (exceeding 500M) is hard to accept. Could we re-think about this? |
@hmcl |