Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORM-2466] The example of jaas.conf in jaas_kerberos.conf should give more details #2058

Closed
wants to merge 6 commits into from
Closed

[STORM-2466] The example of jaas.conf in jaas_kerberos.conf should give more details #2058

wants to merge 6 commits into from

Conversation

liu-zhaokun
Copy link
Contributor

https://issues.apache.org/jira/browse/STORM-2466
This documentation lacks several section such as "Client" and "Server".The Client section is used by processes wanting to talk to ZooKeeper and really only needs to be included with nimbus and the supervisors.The Server section is used by the ZooKeeper servers. "jaas_kerberos.conf" should give users a good lead,so it should should give more details as SECURITY.md .Also,Having unused sections in the jaas is not a problem.So I think The example of jaas.conf in jaas_kerberos.conf should be the same as the PR.

@vesense
Copy link
Member

vesense commented Apr 12, 2017

I guess the change is a copy from http://storm.apache.org/releases/1.1.0/SECURITY.html "Storm Kerberos Configuration" section.
Overall looks good to me.

@liu-zhaokun
Copy link
Contributor Author

@vesense Yes,you are right.

@liu-zhaokun
Copy link
Contributor Author

Hello, @vesense
Could you help me to merge this PR?

@harshach
Copy link
Contributor

@liu-zhaokun why are we including Server section intended for Zookeeper server in this file?

@liu-zhaokun
Copy link
Contributor Author

@harshach
Because the host may be a Storm Server or a Zookeeper Server.Theoretically, they can use the same jaas.conf .

@liu-zhaokun
Copy link
Contributor Author

@harshach
Looking forward to your reply.

@liu-zhaokun
Copy link
Contributor Author

@vesense
Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@vesense
Hi, I am sorry to bother you,could you help me to review it?

@liu-zhaokun
Copy link
Contributor Author

@vesense
Hi,how are you?Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@harshach
Hi,how are you?Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Hi,how are you?Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@harshach
Hello,are you available?

@liu-zhaokun
Copy link
Contributor Author

@vesense
Hi,how are you?Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@HeartSaVioR
Hi,how are you?Could you help me review this PR?

@liu-zhaokun
Copy link
Contributor Author

@harshach
Hi,how are you?Could you help me review this PR?

@harshach
Copy link
Contributor

harshach commented May 9, 2017

@liu-zhaokun I am can help merge this. But my comment is not addressed.
I think its better to break this into two files no?

  1. storm_jaas.conf which contains storm related sections only StormServer, StormClient, Client
  2. zookeeeper_jaas.conf which contains Server
    having all of them in one will confuse users as having Server section in storm jaas is not required.

@liu-zhaokun liu-zhaokun closed this Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@liu-zhaokun @vesense @harshach