STORM-2479: Fix port assignment race condition in storm-webapp tests #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdo
force-pushed
the
STORM-2479
branch
5 times, most recently
from
8b79336
to
f61f405
Compare
|
Earlier test failure seems unrelated, was a windowing bolt test failure. |
HeartSaVioR
reviewed
Apr 18, 2017
| } | ||
|
|
||
| public void stop() { | ||
| if (_server != null) | ||
| _server.stop(); | ||
| _server.stop(); |
There was a problem hiding this comment.
_server is still able to be null, so checking null would be safer.
(I'm assuming AuthUtils.GetTransportPlugin() can return null)
There was a problem hiding this comment.
I checked, AuthUtils.GetTransportPlugin can't return null, and neither included implementation of ITransportPlugin can return null :)
There was a problem hiding this comment.
Heh great. Thanks for explaining. :)
HeartSaVioR
reviewed
Apr 18, 2017
| } | ||
|
|
||
| /** | ||
| * @return true if ThriftServer is listening to requests? | ||
| */ | ||
| public boolean isServing() { | ||
| return _server != null && _server.isServing(); | ||
| return _server.isServing(); |
|
Change looks good. Minor comments. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/STORM-2479
I think we should get rid of Utils.getAvailablePort entirely, but removing it from storm-webapp first seemed like a good opportunity to figure out how difficult it is.