Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-2666 (1.x) #2356

Merged
merged 2 commits into from Oct 9, 2017
Merged

STORM-2666 (1.x) #2356

merged 2 commits into from Oct 9, 2017

Conversation

srdo
Copy link
Contributor

@srdo srdo commented Oct 4, 2017

Please see #2277. I've put all the changes for this branch in their own commit for easy review.

@srdo
STORM-2666: Fix storm-kafka-client spout sometimes emitting messages …
9b95f3d 
…that were already committed. Expand tests, add some runtime validation, minor refactoring to increase code readability. Ensure OffsetManager commits as many offsets as possible when an offset void (deleted offsets) occurs, rather than just up to the gap.
@srdo
Backport to Java 7 and revert changes to RetryService API
54fdcbc
@srdo srdo mentioned this pull request Oct 4, 2017
Merged
@HeartSaVioR
Copy link
Contributor

+1
The build ran fine locally with JDK 7. The Travis build failure came from stuck on AvroGenericRecordBoltTest in storm-hdfs with JDK 7, not in local but often in Travis CI build.

@asfgit asfgit merged commit 54fdcbc into apache:1.x-branch Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@srdo @HeartSaVioR @asfgit