[STORM-3018] Fix integration test DemoTest#testExclamationTopology fa… #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
force-pushed
the
fix-test
branch
2 times, most recently
from
4d6cff5
to
6e2001b
Compare
srdo
reviewed
Apr 1, 2018
conf/defaults.yaml
Outdated
| @@ -195,7 +195,7 @@ worker.log.level.reset.poll.secs: 30 | |||
| # control how many worker receiver threads we need per worker | |||
| topology.worker.receiver.thread.count: 1 | |||
|
|
|||
| # Executor metrics reporting interval. | |||
| # Executor metrics reporting interval, keep default val same with topology.builtin.metrics.bucket.size.secs | |||
There was a problem hiding this comment.
Nit: Could you add to the comment the reason why these must be kept in sync?
There was a problem hiding this comment.
Because:
- the internal metrics interval is set up by conf: topology.builtin.metrics.bucket.size.secs, we should keep sync with it
- Now we use ZK to store our metrics and the ui only show built in metrics, the metrics consumer's collecting interval are also default to 60 seconds
There was a problem hiding this comment.
Thanks, but I meant add a note to the comment. I can't tell from the current comment why the two properties need to be in sync, so I'd have to look up this PR to see why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For STORM-2693 i changed the task metrics reporting interval default to 60 seconds, which is same with the DemoTest#testExclamationTopology check time.
So fix it here.
See STORM-3018