STORM-3168 prevent AsyncLocalizer cleanup from crashing #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, but do we really want to catch the Error subtypes as well? |
|
If an error occurred, what should be the expected behavior? Shutdown? |
|
Yes, we probably don't want to keep running if we hit an Error. |
agresch
force-pushed
the
agresch_localizercleanup
branch
from
15b7238
to
e15110f
Compare
agresch
force-pushed
the
agresch_localizercleanup
branch
from
e15110f
to
5c6e102
Compare
|
@srdo - updated to shutdown on errors. Filed https://issues.apache.org/jira/browse/STORM-3174 to standardize exit codes. I'm not clear on why we're selecting the values we are. |
|
Thanks. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just catching and logging any error that may be occurring.